reform frontend out of Docker stuff + other Docker #130
Conversation
+ other Docker things to get all images on cli: docker build -t t:latest-celery-fast . --target=celery-fast docker build -t t:latest-celery-slow . --target=celery-slow docker build -t t:latest . --target=api docker build -t t:latest-gpu -f gpu.Dockerfile . (compose: see docker-compose files)
| @@ -3,10 +3,11 @@ services: | |||
| nginx: | |||
| build: ./nginx | |||
| api: | |||
| build: . | |||
| build: | |||
| target: api | |||
There was a problem hiding this comment.
| target: api | |
| context: . | |
| target: api |
Unable to run docker compose without the context field for api and other services
There was a problem hiding this comment.
huh, I had the issue the other way around (when context had subargs, target was needed)
(tested the thing asw)
There was a problem hiding this comment.
might be that here.. it does not have subargs :)
|
Thanks for reorganizing! I'd like to keep the existing behaviour with |
|
Would using a separate Dockerfile for debug (stop at step before adding frontend + frontend separate)/prod be fine? |
|
anygay, I'll try to split up the commit if I can edit: can do: include frontend in api, but it can be overwritten by mounting to the same location (making using frontend image optional) |
|
Yeah that's fine |
to get all images on cli:
docker build -t t:latest-celery-fast . --target=celery-fast
docker build -t t:latest-celery-slow . --target=celery-slow
docker build -t t:latest . --target=api
docker build -t t:latest-gpu -f gpu.Dockerfile .
(compose: see docker-compose files)
Closes #122
GPU not tested, others tested.